New JYU-LB wrapper #40
Conversation
kemattil
commented
Apr 26, 2017
kemattil
commented
- a wrapper using the new cuds design
- also a wrapper for the new version of JYU-LB: the new version is implemented as a python extension module (jyulb, a pure Cython implementation); the old version was written in C++ complemented with a Cython interface
- the old wrapper for the old version of JYU-LB is now moved to the folder jyulb_cpp (a temporary backup, will be removed later)
- the new wrapper is located in the wrapper folder
- example SimPhoNy simulation scripts utilizing the new wrapper (and the new cuds design) are located in the examples folder
- one unit test, mainly for checking that the wrapper (and JYU-LB) are installed properly
|
@ahashibon perhaps you would like to have a look on the wrapper implementation and the examples? @mehdisadeghi the wrapper implementation and installation/setup could be of interest to you? @stefanoborini the installation/setup must definitely be checked (are you available?). Furthermore, do you see any conflict with/implications to the other PR #39 ? Finally, I don't know what is the current status/plan for the unit test of wrappers (since the dataset manipulation routines in the ABCModellingEngine API are apparently (?) depreciated) ... |
|
|
||
| class TestProxyLattice(ABCCheckLattice, unittest.TestCase): | ||
|
|
||
| # def setUp(self): |
There was a problem hiding this comment.
remove commented code.
| @@ -0,0 +1,93 @@ | |||
| import domain | |||
There was a problem hiding this comment.
what is the purpose of this file? is it a test? if so, it should be made into a test. If it's an example, it should be under examples.
| np_size[0:len(size)] = size[:] | ||
| np_orig[0:len(origin)] = origin[:] | ||
|
|
||
| # if size_n > 0: |
| 'jyulb.internal.isothermal.jyulb_engine' | ||
| ] | ||
| }, | ||
| # install_requires=['numpy>=1.9.1','simphony>=0.6','jyulb>=0.2.0'], |
|
@stefanoborini please do not consider the folder jyu_cpp (it is just a temporary backup, see the PR description); here the relevant folders are examples and wrapper + installation/setup files. |
|
@kemattil why do you need a temporary backup? we have a versioning system if you want to recover something at a later stage. |
